Bug 199325 - Make ScrollbarControlSize an enum class
Summary: Make ScrollbarControlSize an enum class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-28 10:32 PDT by Simon Fraser (smfr)
Modified: 2020-07-17 11:39 PDT (History)
12 users (show)

See Also:

Attachments
Patch (23.11 KB, patch)
2019-06-28 10:33 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (23.83 KB, patch)
2020-07-16 11:07 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (25.35 KB, patch)
2020-07-17 01:02 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (26.86 KB, patch)
2020-07-17 03:57 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (26.86 KB, patch)
2020-07-17 04:23 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-06-28 10:32:47 PDT 
Make ScrollbarControlSize an enum class
Comment 1 Simon Fraser (smfr) 2019-06-28 10:33:33 PDT 
Created attachment 373129 [details]
Patch
Comment 2 EWS Watchlist 2019-06-28 10:36:01 PDT 
Attachment 373129 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mac/ScrollbarThemeMac.mm:301:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2019-07-05 12:59:37 PDT 
Comment on attachment 373129 [details]
Patch

rs=me, but please get it building first.
Comment 4 Rob Buis 2020-07-16 11:07:06 PDT 
Created attachment 404466 [details]
Patch
Comment 5 Rob Buis 2020-07-17 01:02:26 PDT 
Created attachment 404548 [details]
Patch
Comment 6 Rob Buis 2020-07-17 03:57:45 PDT 
Created attachment 404554 [details]
Patch
Comment 7 Rob Buis 2020-07-17 04:23:54 PDT 
Created attachment 404555 [details]
Patch
Comment 8 Rob Buis 2020-07-17 10:22:52 PDT 
Simon, it looks like this works after rebasing, so if you still want it feel free to commit.
Comment 9 EWS 2020-07-17 11:38:09 PDT 
Committed r264525: <https://trac.webkit.org/changeset/264525>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404555 [details].
Comment 10 Radar WebKit Bug Importer 2020-07-17 11:39:18 PDT 
<rdar://problem/65736048>