Bug 199305

Summary: Web Inspector: support `console.screenshot` with subclasses of CanvasRenderingContext
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 199308    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Devin Rousso
Reported 2019-06-27 19:41:15 PDT
.
Attachments
Patch (6.27 KB, patch)
2019-06-27 22:30 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (7.78 KB, patch)
2019-07-24 16:05 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (7.78 KB, patch)
2019-07-24 16:46 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-06-27 22:30:19 PDT
Created attachment 373086 [details] Patch
Joseph Pecoraro
Comment 2 2019-07-22 13:20:36 PDT
Comment on attachment 373086 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373086&action=review r=me > Source/WebCore/page/PageConsoleClient.cpp:327 > + if (dataURL.isEmpty() || dataURL == "data:,") { This seems out of place in this patch, or does this happen sometimes with empty contexts?
Devin Rousso
Comment 3 2019-07-24 16:05:42 PDT
Created attachment 374823 [details] Patch
Devin Rousso
Comment 4 2019-07-24 16:46:50 PDT
Created attachment 374835 [details] Patch
WebKit Commit Bot
Comment 5 2019-07-24 17:21:40 PDT
Comment on attachment 374835 [details] Patch Clearing flags on attachment: 374835 Committed r247802: <https://trac.webkit.org/changeset/247802>
WebKit Commit Bot
Comment 6 2019-07-24 17:21:42 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-07-24 17:22:18 PDT
<rdar://problem/53520667>
Note You need to log in before you can comment on or make changes to this bug.