Bug 199304

Summary:

Web Inspector: support `console.screenshot` with ImageData and ImageBitmap

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

199308

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Devin Rousso

Reported 2019-06-27 19:40:09 PDT

Attachments
Patch (5.42 KB, patch) 2019-06-27 22:06 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (7.35 KB, patch) 2019-07-24 15:54 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (7.35 KB, patch) 2019-07-24 16:45 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (7.53 KB, patch) 2019-07-24 19:04 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-06-27 22:06:56 PDT

Created attachment 373084 [details] Patch

Joseph Pecoraro

Comment 2 2019-07-22 13:22:17 PDT

Comment on attachment 373084 [details] Patch r=me

Devin Rousso

Comment 3 2019-07-24 15:54:08 PDT

Created attachment 374822 [details] Patch

Devin Rousso

Comment 4 2019-07-24 16:45:45 PDT

Created attachment 374834 [details] Patch

WebKit Commit Bot

Comment 5 2019-07-24 17:25:04 PDT Comment hidden (obsolete)

Comment on attachment 374834 [details] Patch Rejecting attachment 374834 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 374834, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=374834&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=199304&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 374834 from bug 199304. Fetching: https://bugs.webkit.org/attachment.cgi?id=374834 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 5 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. patching file Source/WebCore/page/PageConsoleClient.cpp Hunk #2 FAILED at 288. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/page/PageConsoleClient.cpp.rej patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. patching file LayoutTests/inspector/console/console-screenshot-expected.txt Hunk #1 FAILED at 1. Hunk #2 succeeded at 31 with fuzz 2 (offset 7 lines). 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/inspector/console/console-screenshot-expected.txt.rej patching file LayoutTests/inspector/console/console-screenshot.html Hunk #1 succeeded at 18 with fuzz 1 (offset 7 lines). Hunk #2 succeeded at 104 with fuzz 1 (offset 19 lines). Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/12805305

Devin Rousso

Comment 6 2019-07-24 19:04:31 PDT

Created attachment 374846 [details] Patch

WebKit Commit Bot

Comment 7 2019-07-24 19:25:11 PDT

Comment on attachment 374846 [details] Patch Clearing flags on attachment: 374846 Committed r247812: <https://trac.webkit.org/changeset/247812>

WebKit Commit Bot

Comment 8 2019-07-24 19:25:13 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2019-07-24 19:27:03 PDT

<rdar://problem/53524531>

Note You need to log in before you can comment on or make changes to this bug.