Bug 199286

Summary: Fix build error on WebCore when disabling ENABLE_INDEXED_DATABASE.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
none
ONE MORE TIME
none
Patch none

Basuke Suzuki
Reported 2019-06-27 14:17:20 PDT
../Source/WebCore/testing/Internals.cpp:2405:12: error: use of undeclared identifier 'IDBTransaction' return IDBTransaction::numberOfIDBTransactions;
Attachments
PATCH (1.58 KB, patch)
2019-06-27 14:24 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
ONE MORE TIME (1.58 KB, patch)
2019-06-27 16:23 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (2.96 KB, patch)
2019-06-27 17:25 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2019-06-27 14:24:33 PDT
Created attachment 373053 [details] PATCH
Basuke Suzuki
Comment 2 2019-06-27 16:23:46 PDT
Created attachment 373067 [details] ONE MORE TIME
Brent Fulgham
Comment 3 2019-06-27 16:33:35 PDT
Comment on attachment 373067 [details] ONE MORE TIME View in context: https://bugs.webkit.org/attachment.cgi?id=373067&action=review > Source/WebCore/testing/Internals.cpp:2406 > +#if ENABLE(INDEXED_DATABASE) I think that if you have this disabled, you need to also disable it in the header, don't you?
Basuke Suzuki
Comment 4 2019-06-27 17:08:22 PDT
Comment on attachment 373067 [details] ONE MORE TIME View in context: https://bugs.webkit.org/attachment.cgi?id=373067&action=review >> Source/WebCore/testing/Internals.cpp:2406 >> +#if ENABLE(INDEXED_DATABASE) > > I think that if you have this disabled, you need to also disable it in the header, don't you? Ah, right. I should do that. Also in idl.
Basuke Suzuki
Comment 5 2019-06-27 17:25:53 PDT
Created attachment 373070 [details] Patch
Basuke Suzuki
Comment 6 2019-06-27 18:17:53 PDT
It passed! Thanks, Brent.
WebKit Commit Bot
Comment 7 2019-06-27 18:49:35 PDT
Comment on attachment 373070 [details] Patch Clearing flags on attachment: 373070 Committed r246917: <https://trac.webkit.org/changeset/246917>
WebKit Commit Bot
Comment 8 2019-06-27 18:49:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-06-27 18:53:48 PDT
<rdar://problem/52300694>
Note You need to log in before you can comment on or make changes to this bug.