Bug 199277

Summary: Protect StorageManager::LocalStorageNamespace::m_storageAreaMap with a mutex
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ggaren, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review-

Alex Christensen
Reported 2019-06-27 10:49:17 PDT
Protect StorageManager::LocalStorageNamespace::m_storageAreaMap with a mutex
Attachments
Patch (9.10 KB, patch)
2019-06-27 10:52 PDT, Alex Christensen 		ggaren: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-06-27 10:52:00 PDT
Created attachment 373036 [details] Patch
Alex Christensen
Comment 2 2019-06-27 10:52:02 PDT
<rdar://problem/52098995>
Sihui Liu
Comment 3 2019-06-27 11:23:27 PDT
https://bugs.webkit.org/show_bug.cgi?id=199278 may solve this?
Geoffrey Garen
Comment 4 2019-06-27 11:37:11 PDT
Given that bug 199278 removes didDestroyStorageArea, I think this patch is obsolete. (Also, given the hang mentioned in bug 199278, this patch would probably cause more hangs.)
Alex Christensen
Comment 5 2019-06-27 13:12:39 PDT
Agreed. That patch is what we should do instead
Note You need to log in before you can comment on or make changes to this bug.