| Summary: | Use JSC_GLIB_API_ENABLED instead of USE(GLIB) as a compile-time check for GLib JSC API | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Konstantin Tokarev <annulen> | ||||
| Component: | JavaScriptCore | Assignee: | Konstantin Tokarev <annulen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cgarcia, ews-watchlist, keith_miller, mark.lam, mcatanzaro, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Konstantin Tokarev
2019-06-27 06:18:20 PDT
Created attachment 373025 [details]
Patch
Comment on attachment 373025 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373025&action=review > Source/JavaScriptCore/heap/Heap.cpp:99 > -#if USE(GLIB) > +#ifdef JSC_GLIB_API_ENABLED How about #if ENABLE(JSC_GLIB_API)? This macro is also used in public headers of JSC where ENABLE() is unavailable. It's possible to introduce another macro ENABLE_JSC_GLIB_API to be used inside implementation code, but I've decided not to multiply entities Comment on attachment 373025 [details]
Patch
OK then. I also missed that it already exists. But why no r?
Comment on attachment 373025 [details]
Patch
Oops, I wanted to check EWS status
Comment on attachment 373025 [details] Patch Attachment 373025 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12592494 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-dfg-eager-no-cjit-validate-phases apiTests Comment on attachment 373025 [details] Patch Clearing flags on attachment: 373025 Committed r246881: <https://trac.webkit.org/changeset/246881> All reviewed patches have been landed. Closing bug. |