Bug 199270

Summary: Use JSC_GLIB_API_ENABLED instead of USE(GLIB) as a compile-time check for GLib JSC API
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: JavaScriptCoreAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, ews-watchlist, keith_miller, mark.lam, mcatanzaro, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2019-06-27 06:18:20 PDT
This change allows building code with enabled USE(GLIB) but without GLib JSC API
Attachments
Patch (3.34 KB, patch)
2019-06-27 06:22 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2019-06-27 06:22:15 PDT
Created attachment 373025 [details] Patch
Michael Catanzaro
Comment 2 2019-06-27 07:21:23 PDT
Comment on attachment 373025 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373025&action=review > Source/JavaScriptCore/heap/Heap.cpp:99 > -#if USE(GLIB) > +#ifdef JSC_GLIB_API_ENABLED How about #if ENABLE(JSC_GLIB_API)?
Konstantin Tokarev
Comment 3 2019-06-27 07:27:11 PDT
This macro is also used in public headers of JSC where ENABLE() is unavailable. It's possible to introduce another macro ENABLE_JSC_GLIB_API to be used inside implementation code, but I've decided not to multiply entities
Michael Catanzaro
Comment 4 2019-06-27 08:00:03 PDT
Comment on attachment 373025 [details] Patch OK then. I also missed that it already exists. But why no r?
Konstantin Tokarev
Comment 5 2019-06-27 08:11:18 PDT
Comment on attachment 373025 [details] Patch Oops, I wanted to check EWS status
EWS Watchlist
Comment 6 2019-06-27 08:24:05 PDT
Comment on attachment 373025 [details] Patch Attachment 373025 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12592494 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-dfg-eager-no-cjit-validate-phases apiTests
Konstantin Tokarev
Comment 7 2019-06-27 08:39:00 PDT
Comment on attachment 373025 [details] Patch Clearing flags on attachment: 373025 Committed r246881: <https://trac.webkit.org/changeset/246881>
Konstantin Tokarev
Comment 8 2019-06-27 08:39:04 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-06-27 08:48:20 PDT
<rdar://problem/52261875>
Note You need to log in before you can comment on or make changes to this bug.