| Summary: | JSC binary not being copied into payload for benchmarking | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Paulo Matos <pmatos> | ||||||
| Component: | Tools / Tests | Assignee: | Paulo Matos <pmatos> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | dewei_zhu, ews-watchlist, fpizlo, jbedard, krollin, rniwa, saam | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Paulo Matos
2019-06-27 04:51:42 PDT
Created attachment 373018 [details]
Patch
Comment on attachment 373018 [details] Patch Attachment 373018 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12591504 New failing tests: webgpu/whlsl-two-dimensional-array.html Created attachment 373024 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
ping! Would anyone care to take a look at this please? I need someone else to verify this is what we want. It seems like if we had wanted this, we would have included the JSC binary in the libPath array, no? I added Filip Pizlo as a reviewer, he's the one who added most of the code in this area. Comment on attachment 373018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373018&action=review > Tools/ChangeLog:9 > + * Scripts/run-jsc-benchmarks: Copy jsc into benchmark temp > + so that's it is properly added into payload. What we going wrong in the current set up? Sorry - I dropped the ball on this one. Let me get this one sorted next. |