Bug 199266 - JSC binary not being copied into payload for benchmarking
Summary: JSC binary not being copied into payload for benchmarking
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Paulo Matos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-27 04:51 PDT by Paulo Matos
Modified: 2022-03-01 01:59 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.22 KB, patch)
2019-06-27 04:53 PDT, Paulo Matos 		pmatos: review?
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.72 MB, application/zip)
2019-06-27 06:09 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paulo Matos 2019-06-27 04:51:42 PDT 
JSC binary not being copied into payload for benchmarking
Comment 1 Paulo Matos 2019-06-27 04:53:05 PDT 
Created attachment 373018 [details]
Patch
Comment 2 EWS Watchlist 2019-06-27 06:09:05 PDT 
Comment on attachment 373018 [details]
Patch

Attachment 373018 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12591504

New failing tests:
webgpu/whlsl-two-dimensional-array.html
Comment 3 EWS Watchlist 2019-06-27 06:09:07 PDT 
Created attachment 373024 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 4 Paulo Matos 2019-07-09 00:14:12 PDT 
ping! Would anyone care to take a look at this please?
Comment 5 Jonathan Bedard 2019-07-09 15:02:35 PDT 
I need someone else to verify this is what we want. It seems like if we had wanted this, we would have included the JSC binary in the libPath array, no?

I added Filip Pizlo as a reviewer, he's the one who added most of the code in this area.
Comment 6 Saam Barati 2019-07-09 15:13:36 PDT 
Comment on attachment 373018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373018&action=review

> Tools/ChangeLog:9
> +        * Scripts/run-jsc-benchmarks: Copy jsc into benchmark temp
> +        so that's it is properly added into payload.

What we going wrong in the current set up?
Comment 7 Paulo Matos 2019-10-17 05:23:26 PDT 
Sorry - I dropped the ball on this one. Let me get this one sorted next.