Bug 199264

Summary:

[JSC] LLInt CLoop can't compile for Windows x64 due to Opcode size

Product:

WebKit

Reporter:

Fujii Hironori <fujii.hironori>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
WIP patch	none
WIP patch	none
WIP patch	none

Fujii Hironori

Reported 2019-06-27 03:13:33 PDT

I get the following compilation error by compiling LLInt CLoop for WinCairo 64bit builds. >------ Build started: Project: JavaScriptCore (JavaScriptCore\JavaScriptCore), Configuration: Debug x64 ------ >LowLevelInterpreter.cpp >C:\webkit\gc\WebKitBuild\Debug\WTF\Headers\wtf/StdLibExtras.h(136,36): error C2338: bitwise_cast size of FromType and ToType must be equal! >C:\webkit\gc\Source\JavaScriptCore\llint\LowLevelInterpreter.cpp(158): message : see reference to function template instantiation 'ToType WTF::bitwise_cast<JSC::Opcode,uintptr_t>(FromType)' being compiled >C:\webkit\gc\Source\JavaScriptCore\llint\LowLevelInterpreter.cpp(158): message : with >C:\webkit\gc\Source\JavaScriptCore\llint\LowLevelInterpreter.cpp(158): message : [ >C:\webkit\gc\Source\JavaScriptCore\llint\LowLevelInterpreter.cpp(158): message : ToType=JSC::Opcode, >C:\webkit\gc\Source\JavaScriptCore\llint\LowLevelInterpreter.cpp(158): message : FromType=uintptr_t >C:\webkit\gc\Source\JavaScriptCore\llint\LowLevelInterpreter.cpp(158): message : ] >Done building project "JavaScriptCore.vcxproj" -- FAILED.

Attachments
Patch (3.04 KB, patch) 2019-06-27 03:22 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
WIP patch (2.81 KB, patch) 2019-07-31 20:02 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
WIP patch (2.12 KB, patch) 2019-07-31 20:30 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
WIP patch (1.43 KB, patch) 2021-08-18 21:22 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2019-06-27 03:22:08 PDT

Created attachment 373015 [details] Patch

EWS Watchlist

Comment 2 2019-06-27 03:23:36 PDT

Attachment 373015 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/parser/Nodes.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Fujii Hironori

Comment 3 2019-07-31 20:02:01 PDT

Created attachment 375281 [details] WIP patch

Fujii Hironori

Comment 4 2019-07-31 20:30:54 PDT

Created attachment 375283 [details] WIP patch

Fujii Hironori

Comment 5 2021-08-18 21:22:18 PDT

Created attachment 435843 [details] WIP patch

Note You need to log in before you can comment on or make changes to this bug.