Bug 199257

Summary: [iOS] Support select all in non-editable element
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, megan_gardner, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar, PlatformOnly
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199475
Bug Depends on:    
Bug Blocks: 190571    
Attachments:
Description Flags
For the bots
none
Patch
none
Patch
none
Patch
none
Patch none

Daniel Bates
Reported 2019-06-26 20:06:57 PDT
We should support select all (Command + a) in non-editable elements on iOS just like we do on Mac.
Attachments
For the bots (761 bytes, patch)
2019-07-02 16:04 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (5.04 KB, patch)
2019-07-02 16:36 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (5.84 KB, patch)
2019-07-02 20:50 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (9.47 KB, patch)
2019-07-03 16:16 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (9.56 KB, patch)
2019-07-03 16:20 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-07-02 16:04:20 PDT
Created attachment 373368 [details] For the bots
Radar WebKit Bug Importer
Comment 2 2019-07-02 16:11:16 PDT
<rdar://problem/52553667>
Daniel Bates
Comment 3 2019-07-02 16:36:18 PDT
Created attachment 373370 [details] Patch I need to check if this is okay to do in iOS 12. At least iBooks on iOS 12 allows select all of non-editable content...need to confirm if this was platform convention and WebKit was being too restrictive. Otherwise, will need to keep existing select all condition for iOS 12 and compile-time switch to return YES otherwise. Thoughts?
Daniel Bates
Comment 4 2019-07-02 18:17:25 PDT
(In reply to Daniel Bates from comment #3) > Created attachment 373370 [details] > Patch > > I need to check if this is okay to do in iOS 12. At least iBooks on iOS 12 > allows select all of non-editable content...need to confirm if this was > platform convention and WebKit was being too restrictive. Otherwise, will > need to keep existing select all condition for iOS 12 and compile-time > switch to return YES otherwise. Thoughts? Need compile time switch. Reviewers shouldn't get scared off because of this
Daniel Bates
Comment 5 2019-07-02 20:50:02 PDT
Created attachment 373380 [details] Patch
Daniel Bates
Comment 6 2019-07-03 16:16:46 PDT
Created attachment 373428 [details] Patch
Daniel Bates
Comment 7 2019-07-03 16:20:13 PDT
Created attachment 373429 [details] Patch
Daniel Bates
Comment 8 2019-07-08 16:08:23 PDT
Comment on attachment 373429 [details] Patch Clearing flags on attachment: 373429 Committed r247233: <https://trac.webkit.org/changeset/247233>
Daniel Bates
Comment 9 2019-07-08 16:08:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.