Bug 199254

Summary: [FTW] Build JavaScriptCore
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ews-watchlist
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 199206    
Attachments:
Description Flags
Patch
none
Patch none

Don Olmstead
Reported 2019-06-26 18:02:00 PDT
Introduce WebKitFTW (For the Win(dows)) port which is OS(WINDOWS) + USE(CURL) + USE(DIRECTX)
Attachments
Patch (9.21 KB, patch)
2019-06-26 18:46 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (9.21 KB, patch)
2019-06-26 18:57 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2019-06-26 18:46:49 PDT
Created attachment 372990 [details] Patch
EWS Watchlist
Comment 2 2019-06-26 18:49:36 PDT
Attachment 372990 [details] did not pass style-queue: ERROR: Source/WTF/wtf/PlatformFTW.cmake:13: Alphabetical sorting problem. "PRIVATE Dbghelp # For symbol handling <dbghelp.h>" should be before "PUBLIC Winmm # For multimedia functions, also used in <timeapi.h>". [list/order] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 3 2019-06-26 18:57:25 PDT
Created attachment 372991 [details] Patch
Brent Fulgham
Comment 4 2019-06-26 19:29:20 PDT
Comment on attachment 372991 [details] Patch Yes! R=Me
Brent Fulgham
Comment 5 2019-06-26 19:30:10 PDT
(In reply to Build Bot from comment #2) > Attachment 372990 [details] did not pass style-queue: > > > ERROR: Source/WTF/wtf/PlatformFTW.cmake:13: Alphabetical sorting problem. > "PRIVATE Dbghelp # For symbol handling <dbghelp.h>" should be before "PUBLIC > Winmm # For multimedia functions, also used in <timeapi.h>". [list/order] > [5] > Total errors found: 1 in 7 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. I don’t think this is a helpful warning.
EWS Watchlist
Comment 6 2019-06-26 21:38:47 PDT
Comment on attachment 372991 [details] Patch Attachment 372991 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12588021 New failing tests: exceptionFuzz.yaml/exceptionFuzz/date-format-xparb.js.exception-fuzz apiTests
Brent Fulgham
Comment 7 2019-06-27 09:23:17 PDT
Comment on attachment 372991 [details] Patch There is no way a set of FTW-specific make files has any impact on JSC tests.
WebKit Commit Bot
Comment 8 2019-06-27 09:54:15 PDT
Comment on attachment 372991 [details] Patch Clearing flags on attachment: 372991 Committed r246884: <https://trac.webkit.org/changeset/246884>
WebKit Commit Bot
Comment 9 2019-06-27 09:54:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.