Summary: | [Payment Request] Perform payment method data IDL conversion in the PaymentRequest constructor | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||
Component: | DOM | Assignee: | Andy Estes <aestes> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, darin, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andy Estes
2019-06-26 11:32:23 PDT
Created attachment 386586 [details]
Patch
Comment on attachment 386586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386586&action=review Looks like there are failures in LayoutTests/http/tests/ssl/applepay/PaymentRequest.https.html > Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:72 > + return Exception { ExistingExceptionError }; Not new: So this is supposed to discard the original exception and replace it with ExistingExceptionError? Slightly surprised but I guess that’s a modern web platform design pattern? > Source/WebCore/Modules/paymentrequest/PaymentHandler.cpp:71 > + UNUSED_PARAM(document); Why not sort these the same order as the order they are passed in? > Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:320 > + return WTFMove(data); Not new: JSValue is a simple scalar so there’s no need to do WTFMove. Created attachment 386629 [details]
Patch
(In reply to Darin Adler from comment #3) > Comment on attachment 386586 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386586&action=review > > Looks like there are failures in > LayoutTests/http/tests/ssl/applepay/PaymentRequest.https.html Fixed. > > > Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:72 > > + return Exception { ExistingExceptionError }; > > Not new: So this is supposed to discard the original exception and replace > it with ExistingExceptionError? Slightly surprised but I guess that’s a > modern web platform design pattern? ExistingExceptionError indicates to the bindings that the original VM exception should be propagated. > > > Source/WebCore/Modules/paymentrequest/PaymentHandler.cpp:71 > > + UNUSED_PARAM(document); > > Why not sort these the same order as the order they are passed in? Fixed. > > > Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:320 > > + return WTFMove(data); > > Not new: JSValue is a simple scalar so there’s no need to do WTFMove. Fixed. Comment on attachment 386629 [details] Patch Clearing flags on attachment: 386629 Committed r253986: <https://trac.webkit.org/changeset/253986> All reviewed patches have been landed. Closing bug. |