Summary: | [SOUP] WebSockets: handle TLS certificate and errors | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, mcatanzaro | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 199151 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Carlos Garcia Campos
2019-06-26 05:30:57 PDT
Created attachment 372918 [details]
Patch
Comment on attachment 372918 [details]
Patch
So now this is a third place where we check the TLS certificate: (1) the normal non-WebSocket codepath, (2) SocketStreamHandleImplSoup.cpp for the previous WebSocket codepath, and (3) now here, for the new WebSocket codepath.
Correct?
I think this is OK if SocketStreamHandleImplSoup.cpp goes away and is no longer used with new WebSockets. Is that right?
Right, SocketStreamHandleImplSoup.cpp will be removed when we enable the new code patch. Honestly it'd make more sense to include this in your patch adding the new WebSocket backend, but whatever. Committed r246878: <https://trac.webkit.org/changeset/246878> |