Bug 199223

Summary: [SOUP] WebSockets: handle TLS certificate and errors
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 199151    
Bug Blocks:    
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2019-06-26 05:30:57 PDT
We need to decide based on the session policy.
Attachments
Patch (2.94 KB, patch)
2019-06-26 05:33 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2019-06-26 05:33:13 PDT
Created attachment 372918 [details] Patch
Michael Catanzaro
Comment 2 2019-06-26 06:55:04 PDT
Comment on attachment 372918 [details] Patch So now this is a third place where we check the TLS certificate: (1) the normal non-WebSocket codepath, (2) SocketStreamHandleImplSoup.cpp for the previous WebSocket codepath, and (3) now here, for the new WebSocket codepath. Correct? I think this is OK if SocketStreamHandleImplSoup.cpp goes away and is no longer used with new WebSockets. Is that right?
Carlos Garcia Campos
Comment 3 2019-06-26 07:00:35 PDT
Right, SocketStreamHandleImplSoup.cpp will be removed when we enable the new code patch.
Michael Catanzaro
Comment 4 2019-06-26 11:02:34 PDT
Honestly it'd make more sense to include this in your patch adding the new WebSocket backend, but whatever.
Carlos Garcia Campos
Comment 5 2019-06-27 01:59:03 PDT
Committed r246878: <https://trac.webkit.org/changeset/246878>
Note You need to log in before you can comment on or make changes to this bug.