Bug 199193

Summary: [ews-build] Combine various patchFailed*Tests properties
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Aakash Jain
Reported 2019-06-25 10:32:24 PDT
Combine various patchFailed*Tests properties. We don't need separate property for each type of test failure. These properties were initially added so that somes build-step can be statically added in build factory and would be executed/skipped based on these flags. This was mostly for build-steps which should be run only after failure, e.g.: UnApplyPatchIfRequired, CompileWebKitToT. For most part, we don't require these flags anymore, since we started using addStepsAfterCurrentStep() method inside steps.py, which add such build-step dynamically as required (only after failure) (e.g.: https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/steps.py#L638). But maybe it's still worth to keep them, as a safeguard against someone accidentally adding such steps in a wrong order in the factory.
Attachments
Patch (6.17 KB, patch)
2019-06-25 10:44 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (6.92 KB, patch)
2019-06-25 17:17 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-06-25 10:44:20 PDT
Created attachment 372841 [details] Patch
Jonathan Bedard
Comment 2 2019-06-25 15:22:08 PDT
I would have expected tests to change with this sort of property modification.
Aakash Jain
Comment 3 2019-06-25 17:17:31 PDT
Created attachment 372883 [details] Patch
Aakash Jain
Comment 4 2019-06-25 17:26:20 PDT
(In reply to Jonathan Bedard from comment #2) > I would have expected tests to change with this sort of property modification. Unit tests are modified for 'patchFailedJSCTests' property. I just updated TestCompileWebKitToT.test_failure() and TestUnApplyPatchIfRequired.test_failure() so that these unit-test test 'patchFailedTests' property as well.
WebKit Commit Bot
Comment 5 2019-06-25 17:56:50 PDT
Comment on attachment 372883 [details] Patch Clearing flags on attachment: 372883 Committed r246822: <https://trac.webkit.org/changeset/246822>
WebKit Commit Bot
Comment 6 2019-06-25 17:56:51 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-06-26 16:13:13 PDT
<rdar://problem/52216813>
Radar WebKit Bug Importer
Comment 8 2019-06-26 16:13:14 PDT
<rdar://problem/52216815>
Note You need to log in before you can comment on or make changes to this bug.