Bug 199164

Summary:

Remove IsITPFirstPartyWebsiteDataRemovalEnabled as runtime check

Product:

WebKit

Reporter:

John Wilander <wilander>

Component:

WebKit Misc.

Assignee:

John Wilander <wilander>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

John Wilander

Reported 2019-06-24 11:06:48 PDT

We've had this toggle as a safety thing since mid-March. No need for it any longer.

Attachments
Patch (10.34 KB, patch) 2019-06-24 11:11 PDT, John Wilander	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-06-24 11:07:20 PDT

<rdar://problem/52061147>

John Wilander

Comment 2 2019-06-24 11:11:59 PDT

Created attachment 372772 [details] Patch

John Wilander

Comment 3 2019-06-24 13:08:46 PDT

The win build error seems weird and unrelated: Processing document /home/buildbot/WebKit/Source/WebCore/Modules/mediastream/MediaDevices.idl did not generate anything at /home/buildbot/WebKit/Source/WebCore/bindings/scripts/CodeGenerator.pm line 243. Generating ../../DerivedSources/JavaScriptCore/JSInternalPromiseConstructor.lut.h Generating ../../DerivedSources/JavaScriptCore/JSModuleLoader.lut.h Generating ../../DerivedSources/JavaScriptCore/JSONObject.lut.h Generating ../../DerivedSources/JavaScriptCore/JSPromiseConstructor.lut.h Generating ../../DerivedSources/JavaScriptCore/JSPromisePrototype.lut.h Generating ../../DerivedSources/JavaScriptCore/MapPrototype.lut.h Generating ../../DerivedSources/JavaScriptCore/NumberConstructor.lut.h C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(209,5): error MSB6006: "cmd.exe" exited with code 1. [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCoreBindings.vcxproj]

Brent Fulgham

Comment 4 2019-06-24 13:25:21 PDT

Comment on attachment 372772 [details] Patch Agreed -- I don't think the Windows thing is related to your patch. Maybe it needs to be kicked into a clean build because of the WebPreferences.yaml change?

John Wilander

Comment 5 2019-06-24 14:07:21 PDT

Comment on attachment 372772 [details] Patch Thanks, Brent!

WebKit Commit Bot

Comment 6 2019-06-24 14:37:32 PDT

Comment on attachment 372772 [details] Patch Clearing flags on attachment: 372772 Committed r246763: <https://trac.webkit.org/changeset/246763>

WebKit Commit Bot

Comment 7 2019-06-24 14:37:33 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.