Summary: | contributors.json not canonicalized since r243297 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | Tools / Tests | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, ews-watchlist, glenn, mcatanzaro, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Michael Catanzaro
2019-06-24 08:18:06 PDT
This patch canonicalizes it without changing the format. Created attachment 372764 [details]
Patch
(In reply to Michael Catanzaro from comment #0) > We could make it canonical form with this simple tweak: (Note this will result in it being added in a ton of places where it's not currently.) Attachment 372764 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 372764 [details]
Patch
No preference as far as I’m concerned. I didn’t know that there was a canonical form.
Committed r246751: <https://trac.webkit.org/changeset/246751> |