Bug 199159

Summary: Fully rename WebKitGTK+ -> WebKitGTK everywhere
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, ews-watchlist, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch cgarcia: review+, cgarcia: commit-queue-

Michael Catanzaro
Reported 2019-06-24 08:01:17 PDT
Fully rename WebKitGTK+ -> WebKitGTK everywhere. Now with 100% less punctuation! I riskily touched some webkitpy files, so let's see if webkitpy touches on EWS.
Attachments
Patch (59.00 KB, patch)
2019-06-24 08:04 PDT, Michael Catanzaro 		cgarcia: review+
cgarcia: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2019-06-24 08:04:45 PDT
Created attachment 372760 [details] Patch
EWS Watchlist
Comment 2 2019-06-24 08:08:20 PDT
Attachment 372760 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp" Total errors found: 1 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 3 2019-06-25 00:50:22 PDT
Comment on attachment 372760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372760&action=review Do not change the NEWS file. > Source/WebKit/gtk/NEWS:5 > +What's new in WebKitGTK 2.25.3? ?
Michael Catanzaro
Comment 4 2019-06-25 07:55:40 PDT
(In reply to Carlos Garcia Campos from comment #3) > Do not change the NEWS file. > > > Source/WebKit/gtk/NEWS:5 > > +What's new in WebKitGTK 2.25.3? > > ? I added that there as a placeholder for you, because you keep forgetting to remove the +. Don't forget!
Michael Catanzaro
Comment 5 2019-06-25 07:56:44 PDT
Committed r246790: <https://trac.webkit.org/changeset/246790>
Note You need to log in before you can comment on or make changes to this bug.