Bug 199157

Summary: [LFC][IFC] Inline runs should be relative to the line's top/left initially
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

alan
Reported 2019-06-24 07:36:55 PDT
so that when the line is moved (floats etc) the individual runs don't need to be moved too.
Attachments
Patch (4.23 KB, patch)
2019-06-24 08:05 PDT, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-24 07:37:39 PDT
<rdar://problem/52053415>
alan
Comment 2 2019-06-24 08:05:43 PDT
Created attachment 372761 [details] Patch
Antti Koivisto
Comment 3 2019-07-05 06:26:48 PDT
Comment on attachment 372761 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372761&action=review > Source/WebCore/layout/inlineformatting/InlineLine.cpp:139 > + // Convert runs from relative to the line top/left to the formatting root's border box top/left. > + run->logicalRect.moveVertically(this->logicalTop()); > + run->logicalRect.moveHorizontally(this->logicalLeft()); Nice
WebKit Commit Bot
Comment 4 2019-07-05 07:24:29 PDT
Comment on attachment 372761 [details] Patch Clearing flags on attachment: 372761 Committed r247153: <https://trac.webkit.org/changeset/247153>
WebKit Commit Bot
Comment 5 2019-07-05 07:24:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.