Bug 199149 – [ews-build] Enable iOS-12-Build queue on new EWS

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Aakash Jain]

Enable iOS-12-Build queue on new EWS in production.

[Aakash Jain]

Created attachment 372746 [details]
Patch

[Aakash Jain]

Note that this queue doesn't run layout-tests (we run layout-tests only on iOS simulator, not on iOS devices).

Sample runs:
Success: https://ews-build.webkit-uat.org/#/builders/38/builds/2
ToT Failure: https://ews-build.webkit-uat.org/#/builders/38/builds/13
Patch Failure: https://ews-build.webkit-uat.org/#/builders/38/builds/16

[Jonathan Bedard]

Comment on attachment 372746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372746&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:42
> +    ALL_QUEUES = ['ios', 'api-ios', 'api-mac', 'bindings', 'gtk', 'ios-sim', 'ios-wk2', 'jsc', 'mac', 'mac-32bit', 'mac-32bit-wk2',

Why did we change this order?

> Tools/BuildSlaveSupport/ews-build/config.json:295
> +      "workernames": ["ews152", "ews154", "ews108", "ews109"]

You mention in your changelog that we're sharing temporarily...why temporarily? This seems like a good idea more generally.

[Aakash Jain]

Comment on attachment 372746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372746&action=review

>> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:42
>> +    ALL_QUEUES = ['ios', 'api-ios', 'api-mac', 'bindings', 'gtk', 'ios-sim', 'ios-wk2', 'jsc', 'mac', 'mac-32bit', 'mac-32bit-wk2',
> 
> Why did we change this order?

So as to display the iOS bubble on the left. e.g.: https://ews.webkit-uat.org/status-bubble/372719/

I mentioned in ChangeLog: "Also display the ios bubble first (left). Going forward will keep the builders to the left and testers to the right."

>> Tools/BuildSlaveSupport/ews-build/config.json:295
>> +      "workernames": ["ews152", "ews154", "ews108", "ews109"]
> 
> You mention in your changelog that we're sharing temporarily...why temporarily? This seems like a good idea more generally.

We can leave them shared as well if we feel that this sharing is helping on this queue.

This is required currently until move ews108 and ews109 from old to new EWS <rdar://problem/52051091>.

[WebKit Commit Bot]

Comment on attachment 372746 [details]
Patch

Clearing flags on attachment: 372746

Committed r246738: <https://trac.webkit.org/changeset/246738>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/52054574>

[Aakash Jain]

Deployed the change to the production. 'ios' bubble is now visible in new EWS bubbles.