Bug 199136

Summary:

Web Inspector: REGRESSION (r246684): Dark Mode: dashboard buttons should have no background

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=199109

Attachments:

Description	Flags
[Image] resume button - dark mode	none
Patch	none

Matt Baker

Reported 2019-06-23 14:16:03 PDT

Broke when the following rule was removed from DefaultDashboardView.css: - body.latest-mac .toolbar .dashboard .item.button { - background: unset; - } Without `body.latest-mac` this selector wouldn't have a high enough specificity to override the ButtonToolbarItem rule that adds the background color. We can fix this with a new rule in DefaultDashboardView.css: @media (prefers-color-scheme: dark) { .toolbar .dashboard .item.button, .toolbar .dashboard .item.button:active { background: none; } } Regressed in https://trac.webkit.org/changeset/246684.

Attachments
[Image] resume button - dark mode (19.85 KB, image/png) 2019-06-23 14:29 PDT, Matt Baker	no flags	Details
Patch (1.62 KB, patch) 2019-06-23 14:32 PDT, Matt Baker	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.