Bug 199125 – REGRESSION(r241980): Web Inspector: Styles: Pressing Tab/Enter on last property no longer focuses on selector on next rule

• Component: Web Inspector
• Status: RESOLVED FIXED

[Nikita Vasilyev]

Focus event handler was removed in https://trac.webkit.org/changeset/241980/webkit.

This no longer starts editing selector:

    startEditingRuleSelector()
    {
        ...
        if (this._style.selectorEditable)
            this._selectorElement.focus();

[Radar WebKit Bug Importer]

<rdar://problem/52011182>

[Nikita Vasilyev]

Created attachment 372667 [details]
[Animated GIF] Bug

[Nikita Vasilyev]

Created attachment 372668 [details]
Patch

[Matt Baker]

Comment on attachment 372668 [details]
Patch

r=me, works as advertised!

I noticed we show the green "change added" treatment for newly added blank properties. Maybe we should delay doing this until some property name text is actually entered.

[WebKit Commit Bot]

Comment on attachment 372668 [details]
Patch

Clearing flags on attachment: 372668

Committed r246713: <https://trac.webkit.org/changeset/246713>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Nikita Vasilyev]

(In reply to Matt Baker from comment #4)
> Comment on attachment 372668 [details]
> Patch
> 
> r=me, works as advertised!
> 
> I noticed we show the green "change added" treatment for newly added blank
> properties. Maybe we should delay doing this until some property name text
> is actually entered.

Posted a patch in Bug 199131 - Web Inspector: Styles: show green highlight for newly added properties only when name and value are present