| Summary: | [ews-build] Upload test results after running layout-tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, ews-watchlist, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2019-06-21 15:20:58 PDT
Created attachment 372658 [details]
Patch
Attachment 372658 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:792: [RunWebKitTests.evaluateCommand] Use of super on an old style class [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:819: [TestRunWebKitTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:819: [TestRunWebKitTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:855: [TestRunWebKit1Tests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:855: [TestRunWebKit1Tests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
Total errors found: 5 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 372658 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372658&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:800 > + self.build.addStepsAfterCurrentStep([ArchiveTestResults(), UploadTestResults(), ExtractTestResults()]) To make sure I'm understanding this correctly, these steps upload the results to the build-master, right? Sort of the same way it works for normal trunk testing? > To make sure I'm understanding this correctly, these steps upload the results to the build-master, right? Sort of the same way it works for normal trunk testing?
Yeah
Comment on attachment 372658 [details] Patch Clearing flags on attachment: 372658 Committed r246737: <https://trac.webkit.org/changeset/246737> All reviewed patches have been landed. Closing bug. |