Bug 199120 - [ews-build] Upload test results after running layout-tests
Summary: [ews-build] Upload test results after running layout-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-21 15:20 PDT by Aakash Jain
Modified: 2019-06-24 08:12 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.50 KB, patch)
2019-06-21 15:23 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-06-21 15:20:58 PDT
EWS should upload test results after running layout-tests. This will allow users to see the test results.
Comment 1 Aakash Jain 2019-06-21 15:23:16 PDT
Created attachment 372658 [details]
Patch
Comment 2 Aakash Jain 2019-06-21 15:23:37 PDT
Sample run: https://ews-build.webkit-uat.org/#/builders/35/builds/8
Comment 3 Build Bot 2019-06-21 15:25:39 PDT Comment hidden (obsolete)
Comment 4 Jonathan Bedard 2019-06-24 07:46:16 PDT
Comment on attachment 372658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372658&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:800
> +            self.build.addStepsAfterCurrentStep([ArchiveTestResults(), UploadTestResults(), ExtractTestResults()])

To make sure I'm understanding this correctly, these steps upload the results to the build-master, right? Sort of the same way it works for normal trunk testing?
Comment 5 Aakash Jain 2019-06-24 07:51:11 PDT
> To make sure I'm understanding this correctly, these steps upload the results to the build-master, right? Sort of the same way it works for normal trunk testing?
Yeah
Comment 6 WebKit Commit Bot 2019-06-24 08:11:09 PDT
Comment on attachment 372658 [details]
Patch

Clearing flags on attachment: 372658

Committed r246737: <https://trac.webkit.org/changeset/246737>
Comment 7 WebKit Commit Bot 2019-06-24 08:11:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-06-24 08:12:23 PDT
<rdar://problem/52054249>