Bug 199120 – [ews-build] Upload test results after running layout-tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

EWS should upload test results after running layout-tests. This will allow users to see the test results.

[Aakash Jain]

Created attachment 372658 [details]
Patch

[Aakash Jain]

Sample run: https://ews-build.webkit-uat.org/#/builders/35/builds/8

[EWS Watchlist]

Attachment 372658 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:792:  [RunWebKitTests.evaluateCommand] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:819:  [TestRunWebKitTests.test_success] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:819:  [TestRunWebKitTests.test_success] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:855:  [TestRunWebKit1Tests.test_success] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:855:  [TestRunWebKit1Tests.test_success] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
Total errors found: 5 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jonathan Bedard]

Comment on attachment 372658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372658&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:800
> +            self.build.addStepsAfterCurrentStep([ArchiveTestResults(), UploadTestResults(), ExtractTestResults()])

To make sure I'm understanding this correctly, these steps upload the results to the build-master, right? Sort of the same way it works for normal trunk testing?

[Aakash Jain]

> To make sure I'm understanding this correctly, these steps upload the results to the build-master, right? Sort of the same way it works for normal trunk testing?
Yeah

[WebKit Commit Bot]

Comment on attachment 372658 [details]
Patch

Clearing flags on attachment: 372658

Committed r246737: <https://trac.webkit.org/changeset/246737>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/52054249>