Bug 199111

Summary: Address reference to UIColor.groupTableViewBackgroundColor in WKPasswordView.mm
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2019-06-21 10:24:03 PDT
WKPasswordView.mm is used on iOS-family devices. However, it doesn't build on tvOS or watchOS when "treat deprecation warnings as errors" is enabled. This build failure is due to a reference to UIColor.groupTableViewBackgroundColor in a branch of non-dark-mode code. Address this by surrounding the reference with ALLOW_DEPRECATED_DECLARATIONS_* macros. Attempting to address the build failure by unconditionally enabling the dark-mode code works for tvOS, but fails for watchOS due to lack of dark-mode support on that platform.
Attachments
Patch (2.00 KB, patch)
2019-06-21 10:25 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-21 10:24:18 PDT
<rdar://problem/51992107>
Keith Rollin
Comment 2 2019-06-21 10:25:29 PDT
Created attachment 372633 [details] Patch
WebKit Commit Bot
Comment 3 2019-06-21 12:12:50 PDT
Comment on attachment 372633 [details] Patch Clearing flags on attachment: 372633 Committed r246687: <https://trac.webkit.org/changeset/246687>
WebKit Commit Bot
Comment 4 2019-06-21 12:12:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.