Bug 199107

Summary: Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andres Gonzalez
Reported 2019-06-21 06:37:34 PDT
Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
Attachments
Patch (13.30 KB, patch)
2019-06-21 07:10 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (13.91 KB, patch)
2019-06-21 13:29 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2019-06-21 07:10:10 PDT
Created attachment 372628 [details] Patch
chris fleizach
Comment 2 2019-06-21 09:26:30 PDT
Comment on attachment 372628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372628&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1035 > + // If this has a link ancestor, check for the aria-haspopup attribute in the ancestor. I think we can write this whole method as return AccessibilityObject::matchedParent(*this, true, [&role] (const AccessibilityObject& object) { return !equalLettersIgnoringASCIICase(object.hasPopupValue()), "false"); }); > LayoutTests/accessibility/ios-simulator/button-with-aria-haspopup-role-expected.txt:15 > +test10 AXTraits: 8256 for aria-haspopup='' it's probably risky to output the actual value of the traits which may change over time. maybe better to verify that the traits are different for an object that has popup and one that does not
Andres Gonzalez
Comment 3 2019-06-21 13:29:51 PDT
Created attachment 372644 [details] Patch
WebKit Commit Bot
Comment 4 2019-06-22 11:59:24 PDT
Comment on attachment 372644 [details] Patch Clearing flags on attachment: 372644 Committed r246715: <https://trac.webkit.org/changeset/246715>
WebKit Commit Bot
Comment 5 2019-06-22 11:59:26 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-06-22 12:03:13 PDT
<rdar://problem/52021559>
Note You need to log in before you can comment on or make changes to this bug.