Bug 19910
| Summary: | Release 1.0.1 fails to build because of printf not being defined | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Hommey <mh+webkit> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | alp |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Bug Depends on: | |||
| Bug Blocks: | 20662 | ||
Mike Hommey
The build fails with the following error messages:
../WebCore/page/gtk/AXObjectCacheAtk.cpp: In member function 'void WebCore::AXObjectCache::postNotification(WebCore::RenderObject*, const WebCore::String&)':
../WebCore/page/gtk/AXObjectCacheAtk.cpp:45: error: 'printf' was not declared in this scope
../WebCore/page/gtk/AXObjectCacheAtk.cpp: In member function 'void WebCore::AXObjectCache::postNotificationToElement(WebCore::RenderObject*, const WebCore::String&)':
../WebCore/page/gtk/AXObjectCacheAtk.cpp:76: error: 'printf' was not declared in this scope
../WebCore/page/gtk/AXObjectCacheAtk.cpp: In member function 'void WebCore::AXObjectCache::handleFocusedUIElementChanged()':
../WebCore/page/gtk/AXObjectCacheAtk.cpp:98: error: 'printf' was not declared in this scope
Either #include <stdio.h> should be added, or these printf removed. If these are debug messages, they probably should be sent to stderr, too.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mike Hommey
Note this does only apply to 1.0.1 release. Trunk is free of this.
Alexey Proskuryakov
Should we just close this as resolved then? So far, we haven't been tracking issues in any branches here.
Mike Hommey
I'd say it depends what Alp is going to push the code specific to 1.0.1 onto trunk before new webkitgtk release.
Gustavo Noronha (kov)
I am going to close this because there have been releases after that, and we are not tracking specific branches, as stated. If you disagree please reopen. Thanks.
Mike Hommey
I only see 1.0.1 there:
http://people.freedesktop.org/~alp/webkit/gtk/
(which is the only place i can find with webkit gtk releases...)
Where are these releases that are supposed to have happened ?