Bug 199098

Summary: Web Inspector: rename some DOMObserver method parameters to match the protocol
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Matt Baker
Reported 2019-06-20 19:08:10 PDT
.
Attachments
Patch (1.51 KB, patch)
2019-06-20 19:10 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch (2.54 KB, patch)
2019-06-20 19:37 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2019-06-20 19:10:30 PDT
Created attachment 372608 [details] Patch
Devin Rousso
Comment 2 2019-06-20 19:15:55 PDT
Comment on attachment 372608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372608&action=review > Source/WebInspectorUI/UserInterface/Protocol/DOMObserver.js:80 > + shadowRootPushed(parentNodeId, payload) This doesn't match the name in the protocol either. It should be `hostId` and `root`.
Matt Baker
Comment 3 2019-06-20 19:20:03 PDT
(In reply to Devin Rousso from comment #2) > Comment on attachment 372608 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372608&action=review > > > Source/WebInspectorUI/UserInterface/Protocol/DOMObserver.js:80 > > + shadowRootPushed(parentNodeId, payload) > > This doesn't match the name in the protocol either. It should be `hostId` > and `root`. I chose a poor name for this bug. I wanted to use payload to be consistent with other DOMObserver methods, setChildNodes and childNodeInserted. I can rename payload and payloads in those to match the respective names in the protocol.
Matt Baker
Comment 4 2019-06-20 19:37:03 PDT
Created attachment 372612 [details] Patch
Devin Rousso
Comment 5 2019-06-20 22:11:58 PDT
Comment on attachment 372612 [details] Patch rs=me
WebKit Commit Bot
Comment 6 2019-06-20 22:44:08 PDT
Comment on attachment 372612 [details] Patch Clearing flags on attachment: 372612 Committed r246672: <https://trac.webkit.org/changeset/246672>
WebKit Commit Bot
Comment 7 2019-06-20 22:44:10 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-06-20 22:48:15 PDT
<rdar://problem/51975578>
Note You need to log in before you can comment on or make changes to this bug.