Summary: | [WHLSL] Import bitwise bool tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Justin Fan <justin_fan> | ||||||
Component: | WebGPU | Assignee: | Saam Barati <saam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, mmaxfield, saam, tsavell, webkit-bug-importer | ||||||
Priority: | P1 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 195681 | ||||||||
Attachments: |
|
Description
Justin Fan
2019-06-20 17:24:39 PDT
Neither replacing the 'true' literal with '0 == 0' or the body with: bool b = 0 == 0; result[0] = b; were successful past the checker. The following code also fails in the checker: [numthreads(1, 1, 1)] compute void _compute_main(device bool[] result : register(u0)) {} However, replacing 'bool' with 'int' successfully compiles. Have a fix. We're failing in PODChecker. This is on purpose for various reasons. The main one being we aren't specifying bool's bit pattern. So we are going to make the harness work around this. Created attachment 373056 [details]
WIP
Created attachment 373248 [details]
patch
Comment on attachment 373248 [details] patch Clearing flags on attachment: 373248 Committed r247067: <https://trac.webkit.org/changeset/247067> All reviewed patches have been landed. Closing bug. Looks like the new test webgpu/whlsl-bitwise-bool-ops.html added in https://trac.webkit.org/changeset/247067/webkit is timing out on Mojave Debug WK2 History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgpu%2Fwhlsl-bitwise-bool-ops.html |