Bug 199093

Summary:

[WHLSL] Import bitwise bool tests

Product:

WebKit

Reporter:

Justin Fan <justin_fan>

Component:

WebGPU

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, mmaxfield, saam, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

195681

Attachments:

Description	Flags
WIP	none
patch	none

Justin Fan

Reported 2019-06-20 17:24:39 PDT

The following code fails to compile in the checker: [numthreads(1, 1, 1)] compute void _compute_main(device bool[] result : register(u0)) { result[0] = true; } However, it works if int/uint/uchar/float or float4 is substituted for bool (with a matching literal assignment).

Attachments
WIP (11.05 KB, patch) 2019-06-27 15:12 PDT, Saam Barati	no flags	Details Formatted Diff Diff
patch (16.89 KB, patch) 2019-07-01 12:29 PDT, Saam Barati	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Justin Fan

Comment 1 2019-06-20 17:28:13 PDT

Neither replacing the 'true' literal with '0 == 0' or the body with: bool b = 0 == 0; result[0] = b; were successful past the checker.

Justin Fan

Comment 2 2019-06-25 16:31:32 PDT

The following code also fails in the checker: [numthreads(1, 1, 1)] compute void _compute_main(device bool[] result : register(u0)) {} However, replacing 'bool' with 'int' successfully compiles.

Saam Barati

Comment 3 2019-06-26 16:27:41 PDT

Have a fix. We're failing in PODChecker.

Saam Barati

Comment 4 2019-06-26 16:35:47 PDT

This is on purpose for various reasons. The main one being we aren't specifying bool's bit pattern. So we are going to make the harness work around this.

Saam Barati

Comment 5 2019-06-27 15:12:35 PDT

Created attachment 373056 [details] WIP

Saam Barati

Comment 6 2019-07-01 12:29:15 PDT

Created attachment 373248 [details] patch

WebKit Commit Bot

Comment 7 2019-07-02 12:06:50 PDT

Comment on attachment 373248 [details] patch Clearing flags on attachment: 373248 Committed r247067: <https://trac.webkit.org/changeset/247067>

WebKit Commit Bot

Comment 8 2019-07-02 12:06:52 PDT

All reviewed patches have been landed. Closing bug.