Bug 199080

Summary: WebKit context menu highlights include extra padding
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2019-06-20 14:31:13 PDT
WebKit context menu highlights include extra padding
Attachments
Patch (8.15 KB, patch)
2019-06-20 14:31 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (11.64 KB, patch)
2019-06-21 13:50 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2019-06-20 14:31:36 PDT
Created attachment 372584 [details] Patch
Tim Horton
Comment 2 2019-06-20 14:31:38 PDT
<rdar://problem/51140126>
Dean Jackson
Comment 3 2019-06-20 14:47:59 PDT
Comment on attachment 372584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372584&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2069 > + request.linkIndicatorShouldHaveLegacyMargins = !self._shouldUseContextMenus; It doesn't matter but _shouldUseContextMenus is a method. It probably should be actually declared as a property as well. Is this code within HAVE(LINK_PREVIEW)? I know the others are.
Tim Horton
Comment 4 2019-06-20 14:54:18 PDT
Comment on attachment 372584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372584&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2069 >> + request.linkIndicatorShouldHaveLegacyMargins = !self._shouldUseContextMenus; > > It doesn't matter but _shouldUseContextMenus is a method. It probably should be actually declared as a property as well. > > Is this code within HAVE(LINK_PREVIEW)? I know the others are. It's not. Perhaps I'll move _shouldUseContextMenus out of HAVE(LINK_PREVIEW) (and make it a property)
Tim Horton
Comment 5 2019-06-21 13:50:11 PDT
Created attachment 372645 [details] Patch
WebKit Commit Bot
Comment 6 2019-06-21 14:22:57 PDT
Comment on attachment 372645 [details] Patch Clearing flags on attachment: 372645 Committed r246697: <https://trac.webkit.org/changeset/246697>
WebKit Commit Bot
Comment 7 2019-06-21 14:22:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.