Summary: | WebKit context menu highlights include extra padding | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2019-06-20 14:31:13 PDT
Created attachment 372584 [details]
Patch
Comment on attachment 372584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372584&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2069 > + request.linkIndicatorShouldHaveLegacyMargins = !self._shouldUseContextMenus; It doesn't matter but _shouldUseContextMenus is a method. It probably should be actually declared as a property as well. Is this code within HAVE(LINK_PREVIEW)? I know the others are. Comment on attachment 372584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372584&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2069 >> + request.linkIndicatorShouldHaveLegacyMargins = !self._shouldUseContextMenus; > > It doesn't matter but _shouldUseContextMenus is a method. It probably should be actually declared as a property as well. > > Is this code within HAVE(LINK_PREVIEW)? I know the others are. It's not. Perhaps I'll move _shouldUseContextMenus out of HAVE(LINK_PREVIEW) (and make it a property) Created attachment 372645 [details]
Patch
Comment on attachment 372645 [details] Patch Clearing flags on attachment: 372645 Committed r246697: <https://trac.webkit.org/changeset/246697> All reviewed patches have been landed. Closing bug. |