Bug 199077

Summary: [bmalloc] IsoTLS Layout extension initializes one IsoTLSEntry twice
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, fpizlo, ggaren, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2019-06-20 13:35:53 PDT
If startEntry == oldLastEntry and IsoTLS is expanded, we construct the same entry twice.
Attachments
Patch (3.04 KB, patch)
2019-06-21 02:03 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (3.06 KB, patch)
2019-06-21 02:12 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (3.88 KB, patch)
2019-06-21 12:36 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-06-21 02:03:01 PDT
Created attachment 372622 [details] Patch
Yusuke Suzuki
Comment 2 2019-06-21 02:12:40 PDT
Created attachment 372623 [details] Patch
EWS Watchlist
Comment 3 2019-06-21 04:10:42 PDT
Comment on attachment 372623 [details] Patch Attachment 372623 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12540028 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-no-ftl apiTests
Yusuke Suzuki
Comment 4 2019-06-21 10:20:54 PDT
(In reply to Build Bot from comment #3) > Comment on attachment 372623 [details] > Patch > > Attachment 372623 [details] did not pass jsc-ews (mac): > Output: https://webkit-queues.webkit.org/results/12540028 > > New failing tests: > mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-no-ftl > apiTests This is flaky test
Yusuke Suzuki
Comment 5 2019-06-21 12:36:57 PDT
Created attachment 372639 [details] Patch
Saam Barati
Comment 6 2019-06-21 14:30:05 PDT
Comment on attachment 372639 [details] Patch r=me
Yusuke Suzuki
Comment 7 2019-06-21 14:31:34 PDT
Committed r246698: <https://trac.webkit.org/changeset/246698>
Radar WebKit Bug Importer
Comment 8 2019-06-21 14:32:17 PDT
<rdar://problem/52002682>
Note You need to log in before you can comment on or make changes to this bug.