Bug 199077

Summary: [bmalloc] IsoTLS Layout extension initializes one IsoTLSEntry twice
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, fpizlo, ggaren, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch saam: review+

Description Yusuke Suzuki 2019-06-20 13:35:53 PDT
If startEntry == oldLastEntry and IsoTLS is expanded, we construct the same entry twice.
Comment 1 Yusuke Suzuki 2019-06-21 02:03:01 PDT
Created attachment 372622 [details]
Patch
Comment 2 Yusuke Suzuki 2019-06-21 02:12:40 PDT
Created attachment 372623 [details]
Patch
Comment 3 EWS Watchlist 2019-06-21 04:10:42 PDT
Comment on attachment 372623 [details]
Patch

Attachment 372623 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/12540028

New failing tests:
mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-no-ftl
apiTests
Comment 4 Yusuke Suzuki 2019-06-21 10:20:54 PDT
(In reply to Build Bot from comment #3)
> Comment on attachment 372623 [details]
> Patch
> 
> Attachment 372623 [details] did not pass jsc-ews (mac):
> Output: https://webkit-queues.webkit.org/results/12540028
> 
> New failing tests:
> mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-no-ftl
> apiTests

This is flaky test
Comment 5 Yusuke Suzuki 2019-06-21 12:36:57 PDT
Created attachment 372639 [details]
Patch
Comment 6 Saam Barati 2019-06-21 14:30:05 PDT
Comment on attachment 372639 [details]
Patch

r=me
Comment 7 Yusuke Suzuki 2019-06-21 14:31:34 PDT
Committed r246698: <https://trac.webkit.org/changeset/246698>
Comment 8 Radar WebKit Bug Importer 2019-06-21 14:32:17 PDT
<rdar://problem/52002682>