| Summary: | [ews-build] Add unit tests for AnalyzeCompileWebKitResults | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, ews-watchlist, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2019-06-20 11:16:33 PDT
Created attachment 372573 [details]
Patch
Attachment 372573 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:569: [TestAnalyzeCompileWebKitResults.test_patch_with_build_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:569: [TestAnalyzeCompileWebKitResults.test_patch_with_build_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:578: [TestAnalyzeCompileWebKitResults.test_patch_with_ToT_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:578: [TestAnalyzeCompileWebKitResults.test_patch_with_ToT_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
Total errors found: 4 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 372573 [details] Patch Clearing flags on attachment: 372573 Committed r246650: <https://trac.webkit.org/changeset/246650> All reviewed patches have been landed. Closing bug. |