| Summary: | [GTK] Stop pretending WebCore::Widget can have a platform widget | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro | ||||
| Priority: | P2 | Keywords: | Gtk | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2019-06-20 04:11:18 PDT
Created attachment 372550 [details]
Patch
Comment on attachment 372550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372550&action=review Wow, this survived a really long time. > Source/WebKit/ChangeLog:8 > + Rename PlatformWidget as PlatformViewWidget to avoid conflict with PlatformWidget defined in WebCore. Perhaps you hit a unified build issue? WebCore::PlatformWidget and WebKit::PlatformWidget are not the same and should not conflict except when a source file that is using namespace WebCore; gets unified into another source file that isn't expecting it. Anyway, this change is harmless and I think we can skirt the owner rules if it's a build issue. Those ifdefs are usually defined outside the namespace, because Namespace::GtkWidget doesn't exist, for example. It has worked so far because we were using GtkWidget in both places. Committed r246669: <https://trac.webkit.org/changeset/246669> |