Bug 199058

Summary: `webkit-patch upload -g` uploaded patches to the wrong bug
Product: WebKit Reporter: Dean Johnson <dean_johnson>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: ap, jbedard
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Incorrect upload for `webkit upload-patch -g HEAD~2`
none
Incorrect upload for `webkit upload-patch -g HEAD~1` none

Dean Johnson
Reported 2019-06-19 23:03:24 PDT
Created attachment 372536 [details] Incorrect upload for `webkit upload-patch -g HEAD~2` I had three commits locally I was working on in sequence, and wanted to upload them to separate bugs. I used the commands: ➜ perf.webkit.org git:(summary-page-improvements) webkit-patch upload -g HEAD~2 Total errors found: 0 in 2 files Was that diff correct? [Y/n]: Logging in as dean_johnson@apple.com... Fetching: https://bugs.webkit.org/show_bug.cgi?id=199054&ctype=xml&excludefield=attachmentdata Fetching: https://bugs.webkit.org/show_bug.cgi?id=199054&ctype=xml&excludefield=attachmentdata Assigning bug 199054 to dean_johnson@apple.com Adding patch "Patch" to https://bugs.webkit.org/show_bug.cgi?id=199054 ChangeLog for that commit attached as 'incorrect-upload-HEAD~2.diff`. That should have gone to https://bugs.webkit.org/show_bug.cgi?id=199050. Next, the same thing happened with HEAD~1: ➜ perf.webkit.org git:(summary-page-improvements) webkit-patch upload -g HEAD~1 Total errors found: 0 in 8 files Was that diff correct? [Y/n]: Logging in as dean_johnson@apple.com... Fetching: https://bugs.webkit.org/show_bug.cgi?id=199054&ctype=xml&excludefield=attachmentdata Obsoleting 1 old patch on bug 199054 Obsoleting attachment: 372534 Fetching: https://bugs.webkit.org/show_bug.cgi?id=199054&ctype=xml&excludefield=attachmentdata Adding patch "Patch" to https://bugs.webkit.org/show_bug.cgi?id=199054 ChangeLog for that commit attached as 'incorrect-upload-HEAD~1.diff` That should have gone to https://bugs.webkit.org/show_bug.cgi?id=199051.
Attachments
Incorrect upload for `webkit upload-patch -g HEAD~2` (4.31 KB, text/plain)
2019-06-19 23:03 PDT, Dean Johnson 		no flags
Details
Incorrect upload for `webkit upload-patch -g HEAD~1` (28.07 KB, text/plain)
2019-06-19 23:03 PDT, Dean Johnson 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Dean Johnson
Comment 1 2019-06-19 23:03:52 PDT
Created attachment 372537 [details] Incorrect upload for `webkit upload-patch -g HEAD~1`
Dean Johnson
Comment 2 2019-06-19 23:07:58 PDT
Also failing using `webkit-patch upload -g 7df5f9b5a5e730baacf91b9385a321ee3c1b808d` which corresponds to HEAD~2.
Note You need to log in before you can comment on or make changes to this bug.