Bug 199057

Summary: [LFC][IFC] Make the initial strut explicit
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2019-06-19 21:17:19 PDT
so that we can ignore it in quirks mode
Comment 1 Radar WebKit Bug Importer 2019-06-19 21:18:04 PDT
<rdar://problem/51927864>
Comment 2 zalan 2019-06-19 21:31:26 PDT
Created attachment 372529 [details]
Patch
Comment 3 Antti Koivisto 2019-06-20 05:12:53 PDT
Comment on attachment 372529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372529&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp:137
>      auto initialLineConstraints = Line::InitialConstraints {
>          lineInput.horizontalConstraint.logicalTopLeft,
>          lineInput.horizontalConstraint.availableLogicalWidth,
> -        mimimumLineHeight,
> -        initialBaselineOffset
> +        heightConstraints.height,
> +        heightConstraints.baselineOffset,
> +        heightConstraints.strut
>      };

Should InitialConstraints just have HeightConstraints member?
Comment 4 zalan 2019-06-20 07:19:04 PDT
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 372529 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372529&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp:137
> >      auto initialLineConstraints = Line::InitialConstraints {
> >          lineInput.horizontalConstraint.logicalTopLeft,
> >          lineInput.horizontalConstraint.availableLogicalWidth,
> > -        mimimumLineHeight,
> > -        initialBaselineOffset
> > +        heightConstraints.height,
> > +        heightConstraints.baselineOffset,
> > +        heightConstraints.strut
> >      };
> 
> Should InitialConstraints just have HeightConstraints member?
good point!
Comment 5 zalan 2019-06-20 07:47:59 PDT
Created attachment 372554 [details]
Patch
Comment 6 WebKit Commit Bot 2019-06-20 08:18:33 PDT
Comment on attachment 372554 [details]
Patch

Clearing flags on attachment: 372554

Committed r246634: <https://trac.webkit.org/changeset/246634>
Comment 7 WebKit Commit Bot 2019-06-20 08:18:35 PDT
All reviewed patches have been landed.  Closing bug.