Summary: | [perf.webkit.org] When calculating a ratio for the summary page, use a rolling window for last available data instead of only the last available data point | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Johnson <dean_johnson> | ||||||||
Component: | Tools / Tests | Assignee: | Dean Johnson <dean_johnson> | ||||||||
Status: | RESOLVED LATER | ||||||||||
Severity: | Normal | CC: | dean_johnson, dewei_zhu, rniwa | ||||||||
Priority: | P3 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Dean Johnson
2019-06-19 19:00:26 PDT
Created attachment 372534 [details]
Patch
Created attachment 372535 [details]
Patch
Uploaded patches are incorrect due to https://bugs.webkit.org/show_bug.cgi?id=199058. Uploading new patch soon. Created attachment 372541 [details]
Patch
Spoke with Ryosuke in-person about this. There's another downside I did not consider initially - this change would make it even more difficult to explain how perf-safari is doing its calculations for Summary pages / understand exactly how a number was calculated. Because we're already making changes to the summary page calculations in https://bugs.webkit.org/show_bug.cgi?id=199050, we will hold off on this patch until we have stronger evidence something like it is needed. As it stands, I do not feel strongly about landing it. Resolving this as Later for now. We can reopen it once we decide this is useful. |