Bug 199045

Summary: No menu pop-up when long pressing on a link in Firefox app
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch
none
Patch none

Description Dean Jackson 2019-06-19 17:55:07 PDT 
No menu pop-up when long pressing on a link in Firefox app
Comment 1 Dean Jackson 2019-06-19 17:55:42 PDT 
<rdar://problem/51422407>
Comment 2 Dean Jackson 2019-06-19 17:58:40 PDT 
Created attachment 372505 [details]
Patch
Comment 3 Tim Horton 2019-06-19 17:59:55 PDT 
Comment on attachment 372505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372505&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7450
> +    _previewGestureRecognizer = _previewItemController.get().presentationGestureRecognizer;

IMO [ ] instead of .get() but could go either way
Comment 4 Dean Jackson 2019-06-19 18:02:12 PDT 
Created attachment 372506 [details]
Patch
Comment 5 Dean Jackson 2019-06-19 18:45:45 PDT 
Created attachment 372511 [details]
Patch
Comment 6 Dean Jackson 2019-06-19 19:18:06 PDT 
Committed r246626: <https://trac.webkit.org/changeset/246626>