| Summary: | Add unit test for UIContextMenuConfiguration API | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | aestes, bdakin, dino, ews-watchlist, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Alex Christensen
2019-06-19 17:26:42 PDT
Created attachment 372502 [details]
Patch
Created attachment 372516 [details]
Patch
Created attachment 372531 [details]
Patch
Created attachment 372564 [details]
Patch
Created attachment 372565 [details]
Patch
Comment on attachment 372565 [details] Patch Attachment 372565 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12533588 New failing tests: storage/indexeddb/modern/get-keyrange.html Created attachment 372580 [details]
Archive of layout-test-results from ews211 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 372565 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372565&action=review > Source/WebKit/Platform/spi/ios/UIKitSPI.h:1196 > +@property (nonatomic, weak) id<_UIClickInteractionDriverDelegate> delegate; Nit - I think we usually put a space between id and < for ObjC protocols. > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:799 > +- (id<_UIClickInteractionDriving>)_clickInteractionDriverForTesting Nit - space here too. > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:89 > +@property (nonatomic, setter=_setClickInteractionDriverForTesting:) id<_UIClickInteractionDriving> _clickInteractionDriverForTesting WK_API_AVAILABLE(ios(WK_IOS_TBA)); Nit - space here too. > Tools/TestWebKitAPI/ios/UIKitSPI.h:207 > + Nit - extra newline |