Bug 199043

Summary: Add unit test for UIContextMenuConfiguration API
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, dino, ews-watchlist, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
wenson_hsieh: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews211 for win-future none

Alex Christensen
Reported 2019-06-19 17:26:42 PDT
Add unit test for UIContextMenuConfiguration API
Attachments
Patch (29.37 KB, patch)
2019-06-19 17:33 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (29.41 KB, patch)
2019-06-19 19:24 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (29.46 KB, patch)
2019-06-19 22:19 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (29.45 KB, patch)
2019-06-20 09:55 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (29.56 KB, patch)
2019-06-20 09:56 PDT, Alex Christensen 		wenson_hsieh: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews211 for win-future (13.51 MB, application/zip)
2019-06-20 13:42 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-06-19 17:33:28 PDT
Created attachment 372502 [details] Patch
Alex Christensen
Comment 2 2019-06-19 19:24:20 PDT
Created attachment 372516 [details] Patch
Alex Christensen
Comment 3 2019-06-19 22:19:22 PDT
Created attachment 372531 [details] Patch
Alex Christensen
Comment 4 2019-06-20 09:55:30 PDT
Created attachment 372564 [details] Patch
Alex Christensen
Comment 5 2019-06-20 09:56:49 PDT
Created attachment 372565 [details] Patch
EWS Watchlist
Comment 6 2019-06-20 13:42:50 PDT
Comment on attachment 372565 [details] Patch Attachment 372565 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12533588 New failing tests: storage/indexeddb/modern/get-keyrange.html
EWS Watchlist
Comment 7 2019-06-20 13:42:54 PDT
Created attachment 372580 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Wenson Hsieh
Comment 8 2019-06-20 14:01:14 PDT
Comment on attachment 372565 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372565&action=review > Source/WebKit/Platform/spi/ios/UIKitSPI.h:1196 > +@property (nonatomic, weak) id<_UIClickInteractionDriverDelegate> delegate; Nit - I think we usually put a space between id and < for ObjC protocols. > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:799 > +- (id<_UIClickInteractionDriving>)_clickInteractionDriverForTesting Nit - space here too. > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:89 > +@property (nonatomic, setter=_setClickInteractionDriverForTesting:) id<_UIClickInteractionDriving> _clickInteractionDriverForTesting WK_API_AVAILABLE(ios(WK_IOS_TBA)); Nit - space here too. > Tools/TestWebKitAPI/ios/UIKitSPI.h:207 > + Nit - extra newline
Alex Christensen
Comment 9 2019-06-20 15:29:03 PDT
http://trac.webkit.org/r246657
Radar WebKit Bug Importer
Comment 10 2019-06-20 15:30:25 PDT
<rdar://problem/51962989>
Note You need to log in before you can comment on or make changes to this bug.