Bug 199038

Summary: [iOS] Fall back to taking a UIView snapshohot for UITargetedPreviews if InteractionInformationAtPosition does not have an image
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dino, graouts, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2019-06-19 16:02:41 PDT
[iOS] Fall back to taking a UIView snapshohot for UITargetedPreviews if InteractionInformationAtPosition does not have an image
Attachments
Patch (8.20 KB, patch)
2019-06-19 16:10 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (8.18 KB, patch)
2019-06-19 16:49 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2019-06-19 16:03:23 PDT
rdar://problem/50555810
Andy Estes
Comment 2 2019-06-19 16:10:19 PDT
Created attachment 372498 [details] Patch
Tim Horton
Comment 3 2019-06-19 16:15:24 PDT
Comment on attachment 372498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372498&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7873 > + return adoptNS([[UITargetedPreview alloc] initWithView:snapshotView parameters:parameters.get() target:target.get()]).autorelease(); autoreleasing into a retainptr —— but why?
Andy Estes
Comment 4 2019-06-19 16:49:36 PDT
Created attachment 372500 [details] Patch
WebKit Commit Bot
Comment 5 2019-06-19 17:50:36 PDT
Comment on attachment 372500 [details] Patch Clearing flags on attachment: 372500 Committed r246622: <https://trac.webkit.org/changeset/246622>
WebKit Commit Bot
Comment 6 2019-06-19 17:50:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.