Bug 199038

Summary:

[iOS] Fall back to taking a UIView snapshohot for UITargetedPreviews if InteractionInformationAtPosition does not have an image

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, dino, graouts, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Andy Estes 2019-06-19 16:02:41 PDT

[iOS] Fall back to taking a UIView snapshohot for UITargetedPreviews if InteractionInformationAtPosition does not have an image

Comment 1 Andy Estes 2019-06-19 16:03:23 PDT

rdar://problem/50555810

Comment 2 Andy Estes 2019-06-19 16:10:19 PDT

Created attachment 372498 [details]
Patch

Comment 3 Tim Horton 2019-06-19 16:15:24 PDT

Comment on attachment 372498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372498&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7873
> +    return adoptNS([[UITargetedPreview alloc] initWithView:snapshotView parameters:parameters.get() target:target.get()]).autorelease();

autoreleasing into a retainptr —— but why?

Comment 4 Andy Estes 2019-06-19 16:49:36 PDT

Created attachment 372500 [details]
Patch

Comment 5 WebKit Commit Bot 2019-06-19 17:50:36 PDT

Comment on attachment 372500 [details]
Patch

Clearing flags on attachment: 372500

Committed r246622: <https://trac.webkit.org/changeset/246622>

Comment 6 WebKit Commit Bot 2019-06-19 17:50:37 PDT

All reviewed patches have been landed.  Closing bug.