Bug 199038 - [iOS] Fall back to taking a UIView snapshohot for UITargetedPreviews if InteractionInformationAtPosition does not have an image
Summary: [iOS] Fall back to taking a UIView snapshohot for UITargetedPreviews if Inter...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-19 16:02 PDT by Andy Estes
Modified: 2019-06-19 17:50 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.20 KB, patch)
2019-06-19 16:10 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (8.18 KB, patch)
2019-06-19 16:49 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2019-06-19 16:02:41 PDT
[iOS] Fall back to taking a UIView snapshohot for UITargetedPreviews if InteractionInformationAtPosition does not have an image
Comment 1 Andy Estes 2019-06-19 16:03:23 PDT
rdar://problem/50555810
Comment 2 Andy Estes 2019-06-19 16:10:19 PDT
Created attachment 372498 [details]
Patch
Comment 3 Tim Horton 2019-06-19 16:15:24 PDT
Comment on attachment 372498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372498&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7873
> +    return adoptNS([[UITargetedPreview alloc] initWithView:snapshotView parameters:parameters.get() target:target.get()]).autorelease();

autoreleasing into a retainptr —— but why?
Comment 4 Andy Estes 2019-06-19 16:49:36 PDT
Created attachment 372500 [details]
Patch
Comment 5 WebKit Commit Bot 2019-06-19 17:50:36 PDT
Comment on attachment 372500 [details]
Patch

Clearing flags on attachment: 372500

Committed r246622: <https://trac.webkit.org/changeset/246622>
Comment 6 WebKit Commit Bot 2019-06-19 17:50:37 PDT
All reviewed patches have been landed.  Closing bug.