Summary: | Web Inspector: don't show popover for hovered token when editor scrolls due to find previous/next | ||
---|---|---|---|
Product: | WebKit | Reporter: | Matt Baker <mattbaker> |
Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> |
Status: | NEW --- | ||
Severity: | Normal | CC: | inspector-bugzilla-changes, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=178325 |
Description
Matt Baker
2019-06-19 14:36:15 PDT
Investigating returning early when event.movementX === 0 && event.movementY === 0. While this holds when the editor scrolls due to find previous/next, I'm worried it could cause false positives. (In reply to Matt Baker from comment #2) > Investigating returning early when event.movementX === 0 && event.movementY > === 0. While this holds when the editor scrolls due to find previous/next, > I'm worried it could cause false positives. Ignoring mousemoves for which event.movementX and event.movementY are zero fixes the problem. However, this will cause real mouse movements within the editor to be dropped. Granted these are just for very minute movements of the cursor. Still, I'm hesitant to make the change before exhausting other possible solutions. Note: It looks like the mousemove event that CodeMirrorTokenTrackingController detects when revealing search results in the editor is triggered when the search text is programmatically selected: selectedTextRange (TextEditor.js:217) _revealSearchResult (TextEditor.js:1117) _revealFirstSearchResultAfterCursor (TextEditor.js:1259) markRanges (TextEditor.js:400) runInOp (codemirror.js:3743) addSearchResults (TextEditor.js:404) searchResultCallback (SourceCodeTextEditor.js:245) ... |