Bug 19902

Summary:

[XBL] We need to check nodes for content errors

Product:

WebKit

Reporter:

Julien Chaffraix <jchaffraix>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

dglazkov, ml

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Add a boolean flag and per tag check	eric: review-

Description Julien Chaffraix 2008-07-05 01:35:38 PDT

Nodes in errors (because of its parent) should be marked while parsing. This will enable us to ignore them later when doing some processing (as requested by the specification).

Comment 1 Julien Chaffraix 2008-07-05 01:40:54 PDT

Created attachment 22096 [details]
Add a boolean flag and per tag check

Comment 2 Eric Seidel (no email) 2008-07-06 18:04:51 PDT

Comment on attachment 22096 [details]
Add a boolean flag and per tag check

I'm not sure addChild is the correct place to check.  childrenChanged on XBLElement is probably a better place.

Either way, error checking and propagation isn't a required to get simple things up and running.  I suggest you ask hyatt where the correct place to put this type of checking is... or we just deal with it later when we're further along.

Comment 3 Dimitri Glazkov (Google) 2011-01-22 10:27:25 PST

We ripped this code out and a new implementation is under way.