| Summary: | [WHLSL] The checker needs to resolve types for the anonymous variables in ReadModifyWrite expressions | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
| Component: | WebGPU | Assignee: | Saam Barati <saam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dino, ews-watchlist, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, webkit-bug-importer | ||||||
| Priority: | P1 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Saam Barati
2019-06-18 18:38:48 PDT
Seems like it’s actually name resolution for types patch forthcoming Created attachment 372501 [details]
patch
Attachment 372501 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 372501 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=372501&action=review > Source/WebCore/ChangeLog:11 > + TAB!!!!!!! Security has been called. (In reply to Dean Jackson from comment #5) > Comment on attachment 372501 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372501&action=review > > > Source/WebCore/ChangeLog:11 > > + > > TAB!!!!!!! Security has been called. Vim likes to insert tabs when it auto indents changelog entries. It's super annoying. Thanks for the review. r=me Created attachment 372510 [details]
patch for landing
Comment on attachment 372510 [details] patch for landing Clearing flags on attachment: 372510 Committed r246625: <https://trac.webkit.org/changeset/246625> All reviewed patches have been landed. Closing bug. |