Bug 198983

Summary: [WASM-References] Rename anyfunc to funcref
Product: WebKit Reporter: Justin Michaud <justin_michaud>
Component: JavaScriptCoreAssignee: Justin Michaud <justin_michaud>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews211 for win-future none

Justin Michaud
Reported 2019-06-18 16:43:57 PDT
Anyfunc should become funcref since it was renamed in the spec. We should also support the string 'anyfunc' in the table constructor since this is the only non-binary-format place where it is exposed to users.
Attachments
Patch (133.77 KB, patch)
2019-06-18 18:39 PDT, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews211 for win-future (13.81 MB, application/zip)
2019-06-18 22:26 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Justin Michaud
Comment 1 2019-06-18 18:39:17 PDT
Created attachment 372416 [details] Patch
EWS Watchlist
Comment 2 2019-06-18 18:41:36 PDT
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Yusuke Suzuki
Comment 3 2019-06-18 18:43:15 PDT
Comment on attachment 372416 [details] Patch r=me
EWS Watchlist
Comment 4 2019-06-18 22:26:30 PDT
Comment on attachment 372416 [details] Patch Attachment 372416 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12516291 New failing tests: svg/text/textpath-reference-update.html
EWS Watchlist
Comment 5 2019-06-18 22:26:33 PDT
Created attachment 372434 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Justin Michaud
Comment 6 2019-06-19 08:05:01 PDT
Comment on attachment 372416 [details] Patch Test failures seem unrelated.
WebKit Commit Bot
Comment 7 2019-06-19 08:36:53 PDT
Comment on attachment 372416 [details] Patch Clearing flags on attachment: 372416 Committed r246589: <https://trac.webkit.org/changeset/246589>
WebKit Commit Bot
Comment 8 2019-06-19 08:36:55 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-06-19 08:37:21 PDT
<rdar://problem/51896943>
Note You need to log in before you can comment on or make changes to this bug.