Bug 198981

Summary: DownloadMonitor::measuredThroughputRate should approach zero with no throughput
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Alex Christensen 2019-06-18 16:29:07 PDT
DownloadMonitor::measuredThroughputRate should approach zero with no throughput
Comment 1 Alex Christensen 2019-06-18 16:42:01 PDT
Created attachment 372405 [details]
Patch
Comment 2 Alex Christensen 2019-06-18 16:42:04 PDT
<rdar://problem/51456914>
Comment 3 Geoffrey Garen 2019-06-19 10:31:23 PDT
Comment on attachment 372405 [details]
Patch

r=me

I wonder if our API test can cover this. You'd need to add a way to explicitly set the timer duration for testing, so the test didn't take five minutes. A little gross, but seems doable.
Comment 4 Alex Christensen 2019-06-19 16:06:44 PDT
Comment on attachment 372405 [details]
Patch

We don't have a good way to simulate packet loss.
Comment 5 WebKit Commit Bot 2019-06-19 16:36:41 PDT
Comment on attachment 372405 [details]
Patch

Clearing flags on attachment: 372405

Committed r246615: <https://trac.webkit.org/changeset/246615>
Comment 6 WebKit Commit Bot 2019-06-19 16:36:43 PDT
All reviewed patches have been landed.  Closing bug.