Bug 198970

Summary: Change log channel name from ResourceLoadStatisticsDebug to ITPDebug and remove unnecessary #if !RELEASE_LOG_DISABLED
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

John Wilander
Reported 2019-06-18 10:43:36 PDT
We should change the log channel name for ITP from ResourceLoadStatisticsDebug to ITPDebug and remove unnecessary #if !RELEASE_LOG_DISABLED while we're at it.
Attachments
Patch (18.59 KB, patch)
2019-06-18 10:47 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (18.07 KB, patch)
2019-06-18 11:49 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-18 10:44:10 PDT
<rdar://problem/51855836>
John Wilander
Comment 2 2019-06-18 10:47:37 PDT
Created attachment 372351 [details] Patch
Brent Fulgham
Comment 3 2019-06-18 11:14:12 PDT
Comment on attachment 372351 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372351&action=review Looks good, aside from the unused function. r=me if you fix that. > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:-89 > -#endif I think the build will fail (due to unused function warnings) if you remove these #if/defs.
John Wilander
Comment 4 2019-06-18 11:39:54 PDT
(In reply to Brent Fulgham from comment #3) > Comment on attachment 372351 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372351&action=review > > Looks good, aside from the unused function. r=me if you fix that. > > > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:-89 > > -#endif > > I think the build will fail (due to unused function warnings) if you remove > these #if/defs. Oh, you're saying the RELEASE_LOG_INFO macros will compile out the calls to domainsToString() if release log is disabled and thus cause an unused function build warning/failure?
John Wilander
Comment 5 2019-06-18 11:49:15 PDT
Created attachment 372357 [details] Patch
John Wilander
Comment 6 2019-06-18 11:49:59 PDT
Made the change you asked for and now just making sure EWS is happy since it's a compile-time change.
Brent Fulgham
Comment 7 2019-06-18 11:54:58 PDT
(In reply to John Wilander from comment #4) > (In reply to Brent Fulgham from comment #3) > > Comment on attachment 372351 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=372351&action=review > > > > Looks good, aside from the unused function. r=me if you fix that. > > > > > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:-89 > > > -#endif > > > > I think the build will fail (due to unused function warnings) if you remove > > these #if/defs. > > Oh, you're saying the RELEASE_LOG_INFO macros will compile out the calls to > domainsToString() if release log is disabled and thus cause an unused > function build warning/failure? Precisely! It's because we build with warnings-as-errors.
John Wilander
Comment 8 2019-06-18 12:53:02 PDT
Comment on attachment 372357 [details] Patch Seems fine. Thanks, Brent!
WebKit Commit Bot
Comment 9 2019-06-18 13:22:46 PDT
Comment on attachment 372357 [details] Patch Clearing flags on attachment: 372357 Committed r246561: <https://trac.webkit.org/changeset/246561>
WebKit Commit Bot
Comment 10 2019-06-18 13:22:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.