Bug 198954

Summary:

REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing

Product:

WebKit

Reporter:

David Quesada <david_quesada>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap, commit-queue, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

David Quesada

Reported 2019-06-17 22:20:32 PDT

rdar://problem/51711556

Attachments
Patch (2.64 KB, patch) 2019-06-17 22:35 PDT, David Quesada	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Quesada

Comment 1 2019-06-17 22:35:20 PDT

Created attachment 372328 [details] Patch

David Quesada

Comment 2 2019-06-17 22:39:27 PDT

Before this patch, I ran 30 iterations of these tests locally and saw success rates of 21/30 and 25/30. With this patch, I've run 200 iterations (so far) and haven't seen any failures of either.

WebKit Commit Bot

Comment 3 2019-06-18 10:20:20 PDT

Comment on attachment 372328 [details] Patch Clearing flags on attachment: 372328 Committed r246548: <https://trac.webkit.org/changeset/246548>

WebKit Commit Bot

Comment 4 2019-06-18 10:20:22 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.