Bug 198947

Summary: NetworkSession::networkStorageSession can return null
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2019-06-17 17:55:43 PDT 
NetworkSession::networkStorageSession can return null
Comment 1 Alex Christensen 2019-06-17 17:57:44 PDT 
Created attachment 372304 [details]
Patch
Comment 2 Alex Christensen 2019-06-17 17:57:46 PDT 
<rdar://problem/51394449>
Comment 3 Alex Christensen 2019-06-17 18:01:59 PDT 
Created attachment 372307 [details]
Patch
Comment 4 youenn fablet 2019-06-18 10:28:05 PDT 
Comment on attachment 372307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372307&action=review

> Source/WebKit/ChangeLog:22
> +        (WebKit::WebResourceLoadStatisticsStore::removePrevalentDomains):

ResourceLoadStatisticsStore.cpp/WebResourceLoadStatisticsStore changes should probably not be needed after changes landed in https://bugs.webkit.org/show_bug.cgi?id=198814.
Comment 5 Alex Christensen 2019-06-18 14:20:13 PDT 
Comment on attachment 372307 [details]
Patch

They're just null checks, and a syntax change is needed no matter what, so I'll just land this.  When we fix bug 194926 we'll be back to having references.
Comment 6 WebKit Commit Bot 2019-06-18 14:40:33 PDT 
Comment on attachment 372307 [details]
Patch

Clearing flags on attachment: 372307

Committed r246569: <https://trac.webkit.org/changeset/246569>
Comment 7 WebKit Commit Bot 2019-06-18 14:40:35 PDT 
All reviewed patches have been landed.  Closing bug.