Bug 198941

Summary: Web Inspector: REGRESSION: Heap: subsequent snapshots taken manually don't appear in the list
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Devin Rousso 2019-06-17 16:51:23 PDT 
# STEPS TO REPRODUCE:
1. inspect any page
2. go to the Timelines tab
3. enable "JavaScript Allocations"
4. take a heap snapshot
 => the [S] appears in the graph area and in the "Snapshot List" area
5. take another heap snapshot
 => the [S] appears in the graph area, but _not_ in the "Snapshot List" area
Comment 1 Devin Rousso 2019-06-17 21:26:45 PDT 
Interestingly, it looks like it's only an issue when the entire recording is selected (e.g. double clicking the overview graph area).
Comment 2 Devin Rousso 2019-06-17 21:47:54 PDT 
Created attachment 372323 [details]
Patch
Comment 3 Devin Rousso 2019-06-17 21:49:03 PDT 
Created attachment 372324 [details]
Patch

webkit-patch didn't catch my last changes :(
Comment 4 Joseph Pecoraro 2019-06-18 11:44:00 PDT 
Comment on attachment 372324 [details]
Patch

Nice, r=me
Comment 5 WebKit Commit Bot 2019-06-18 12:33:48 PDT 
Comment on attachment 372324 [details]
Patch

Clearing flags on attachment: 372324

Committed r246558: <https://trac.webkit.org/changeset/246558>
Comment 6 WebKit Commit Bot 2019-06-18 12:33:49 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-06-18 12:34:28 PDT 
<rdar://problem/51860940>