Bug 198901

Summary: [LFC][IFC] Decouple baseline ascent/descent and baseline offset.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Description zalan 2019-06-15 20:54:00 PDT 
baseline offset = baseline top + baseline ascent (baseline's distance from the top of the line -not always the same as baseline ascent)
Comment 1 Radar WebKit Bug Importer 2019-06-15 20:54:25 PDT 
<rdar://problem/51782393>
Comment 2 zalan 2019-06-15 20:59:44 PDT 
Created attachment 372215 [details]
Patch
Comment 3 Antti Koivisto 2019-06-16 11:59:52 PDT 
Comment on attachment 372215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372215&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBox.h:54
> +    // baseline offset from line logical top. Note that offset does not necessarily equal to ascent.

Start with capital letter.

This could use some ascii art!
Comment 4 zalan 2019-06-16 12:00:56 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 372215 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372215&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBox.h:54
> > +    // baseline offset from line logical top. Note that offset does not necessarily equal to ascent.
> 
> Start with capital letter.
> 
> This could use some ascii art!
Indeed!
Comment 5 zalan 2019-06-16 13:42:04 PDT 
Committed r246484: <https://trac.webkit.org/changeset/246484>