Bug 198881

Summary: [LFC] Add limited quirks mode to LayoutState.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2019-06-15 00:33:04 PDT
ssia
Attachments
Patch (3.72 KB, patch)
2019-06-15 00:36 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (3.70 KB, patch)
2019-06-16 08:27 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-15 00:33:29 PDT
<rdar://problem/51773229>
zalan
Comment 2 2019-06-15 00:36:54 PDT
Created attachment 372181 [details] Patch
Sam Weinig
Comment 3 2019-06-15 13:15:07 PDT
Comment on attachment 372181 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372181&action=review > Source/WebCore/layout/LayoutState.h:67 > + void setQuirksMode(QuirksMode quirksMode) { m_quirksMode = quirksMode; } Why not use Document's DocumentCompatibilityMode?
zalan
Comment 4 2019-06-15 13:22:16 PDT
(In reply to Sam Weinig from comment #3) > Comment on attachment 372181 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372181&action=review > > > Source/WebCore/layout/LayoutState.h:67 > > + void setQuirksMode(QuirksMode quirksMode) { m_quirksMode = quirksMode; } > > Why not use Document's DocumentCompatibilityMode? This will definitely change in the future but right now the idea is to be as self-contained as possible.
zalan
Comment 5 2019-06-15 13:23:53 PDT
(In reply to zalan from comment #4) > (In reply to Sam Weinig from comment #3) > > Comment on attachment 372181 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=372181&action=review > > > > > Source/WebCore/layout/LayoutState.h:67 > > > + void setQuirksMode(QuirksMode quirksMode) { m_quirksMode = quirksMode; } > > > > Why not use Document's DocumentCompatibilityMode? > This will definitely change in the future but right now the idea is to be as > self-contained as possible. RenderStyle is the only area where I gave up on being self-contained so far.
zalan
Comment 6 2019-06-16 08:27:16 PDT
Created attachment 372221 [details] Patch
WebKit Commit Bot
Comment 7 2019-06-16 12:30:52 PDT
Comment on attachment 372221 [details] Patch Clearing flags on attachment: 372221 Committed r246477: <https://trac.webkit.org/changeset/246477>
WebKit Commit Bot
Comment 8 2019-06-16 12:30:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.